FEATURE: move the flycli config directory under `.config`

jkthorne · July 12, 2023, 5:04pm

This is not a bug so hopefully this is the best place to ask this. I was doing some local debugging of the CLI and I noticed the .fly directory is in my home directory.

It would be helpful for discovery and maintainability of a system to have this in the .config directory.

It looks like this directory is being found or created here.

github.com

superfly/flyctl/blob/master/flyctl/flyctl.go#L46


      
          func ConfigFilePath() string {
          	return path.Join(configDir, "config.yml")
          }
          
          func initConfigDir() error {
          	homeDir, err := os.UserHomeDir()
          	if err != nil {
          		return err
          	}
          
          	dir := filepath.Join(homeDir, ".fly")
          
          	if !helpers.DirectoryExists(dir) {
          		if err := os.MkdirAll(dir, 0o700); err != nil {
          			return err
          		}
          	}
          
          	configDir = dir
          
          	return nil

Which is helpful because it can be the start or migrating and changing the location here. Before working on this I just wanted to see if this is something the community would be interested in.

lubien · July 12, 2023, 5:17pm

I’m not sure exactly what the goal is in changing this directory.

Can you comment on your use case for having a different dir for flyctl config?

jkthorne · July 13, 2023, 9:39pm

My primary use case is to decrease noise in my home directory.
My secondary use case is to get familiar with the flycli with a problem I want to solve and contribute.

I believe this specification comes from the free desktop project, more specifically the the Directory Specification. Although this specification is primarily for desktop applications I have seen some other projects use a variation of this pattern.

My personal opinion is this seems like a “nice to have” feature.

system · July 20, 2023, 9:40pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.