Would be great to have `release_command` output shown when running `fly deploy`

evsasse · May 1, 2024, 2:33pm

Similar to What happened to `release_command` logs?

Just migrated our bin/rails db:prepare from Heroku’s release step to Fly’s release_command.
And I reeeally miss the ease that we were able to inspect which migrations have run, how much time each of them took, etc. Without each of the devs on our team having to have a degree on the fly CLI.

Not even running with all possible debug/verbose options it shows this release_command output . Eg. LOG_LEVEL=debug flyctl deploy --debug --verbose ....

rubys · May 1, 2024, 5:25pm

Do me a favor. Open an issue on flyctl.

It looks like we currently only show the logs on failure:

github.com

superfly/flyctl/blob/6507fe8b811b7e3528dc0f1f8cda200272f0d952/internal/command/deploy/machines_releasecommand.go#L71


      
          	}
          	lastExitEvent, err := releaseCmdMachine.WaitForEventTypeAfterType(ctx, "exit", "start", md.releaseCmdTimeout, true)
          	if err != nil {
          		return fmt.Errorf("error finding the release_command machine %s exit event: %w", releaseCmdMachine.Machine().ID, err)
          	}
          	exitCode, err := lastExitEvent.Request.GetExitCode()
          	if err != nil {
          		return fmt.Errorf("error get release_command machine %s exit code: %w", releaseCmdMachine.Machine().ID, err)
          	}
          
          	if exitCode != 0 {
          		statuslogger.LogStatus(ctx, statuslogger.StatusFailure, "release_command failed")
          		// Preemptive cleanup of the logger so that the logs have a clean place to write to
          		loggerCleanup(false)
          
          		time.Sleep(2 * time.Second) // Wait 2 secs to be sure logs have reached OpenSearch
          		fmt.Fprintf(md.io.ErrOut, "Error release_command failed running on machine %s with exit code %s.\n",
          			md.colorize.Bold(releaseCmdMachine.Machine().ID), md.colorize.Red(strconv.Itoa(exitCode)))
          		fmt.Fprintf(md.io.ErrOut, "Check its logs: here's the last 100 lines below, or run 'fly logs -i %s':\n",
          			releaseCmdMachine.Machine().ID)
          		releaseCmdLogs, _, err := md.apiClient.GetAppLogs(ctx, md.app.Name, "", md.appConfig.PrimaryRegion, releaseCmdMachine.Machine().ID)

It looks like it would be straightforward to add || flag.GetBool(ctx, "verbose") to that condition.

evsasse · May 1, 2024, 5:44pm

`fly deploy` with `--verbose` should show `release_command` output. · Issue #3510 · superfly/flyctl · GitHub Done .
Thanks for the quick response @rubys .

evsasse · May 3, 2024, 2:24pm

It has been released with flyctl v0.2.47 (Release v0.2.47 · superfly/flyctl · GitHub). Just need to make sure to use the --verbose option. I can confirm it is already working on our Github Actions to make the deploy .

Thanks @rubys .

system · May 10, 2024, 2:24pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
What happened to `release_command` logs?	6	317	July 10, 2023
release_command questions	15	1033	October 28, 2021
Release command failing but there are not logs	4	782	October 11, 2021
Issues with deploy.release_command	6	1037	June 7, 2022
Deploy with Release_command not working docs	0	341	November 23, 2022

Would be great to have `release_command` output shown when running `fly deploy`

Related topics